This is closer to the Icinga spec, anything greater than 2 or 3 is unknown.

No news is good news!

We're just testing, so we don't need super robust error handling code. And if any of those conditions aren't met then we have serious problems anyway.

This reverts commit bd3b8a33c54037e66233db80fd1120eb0b6215f1. It's a bad idea. I'm writing a fake server instead so that we can use the real client code.

So that testing the client doesn't involve making real HTTP requests.

For some reason the API returns an internal server error status rather than a Not Found status (as in other methods in the API). We can catch the condition when results are empty and return ErrNoMatch.

I was excluding some struct fields so I thought I'd need to do some custom marshalling . But you don't need to do this as you can use struct tags to optionally exclude things from being put into JSON. Now there's no longer duplicate code between struct tags and keys in a map when marshalling. Handy!

This was used in some old tests but is now unused.

This is a bit tricky. url.QueryEscape() encodes spaces in queries as "+", but Icinga2 wants them as "%20". A test case is included because this was kinda tricky to debug.

The check was incorrect before. The HTTP status on responses is still 200 OK, but with empty results if there are no matches to the filter.

Before we were just returning an empty response or something non-meaningful

While here document what is needed to actually run go generate.

Includes a test to know that we're handling the JSON properly.

This also adds a test for checking all hosts in a HostGroup.

We were missing some attributes, like not adding any groups or display names. This also adds a test which checks whether we are marshalling hosts into JSON correctly.

And also add a icinga_test package that does the black-box tests i.e. tests which speak to a real icinga server.

getopt(1) clears the value of "$@", so grab it before it's cleared

This adds a newTestClient option so that we aren't constantly creating new http transports clients and all that

Tests of hostgroup operations are done in TestFilter