commit e4d83a7f98a82848e39885880ed4cb0d741058fe from: Oliver Lowe via: Oliver Lowe date: Mon Jul 21 09:29:19 2025 UTC jira: return no error on success lol commit - e80961fe8ae238bac3883d9cffc9fe1941ae7bb6 commit + e4d83a7f98a82848e39885880ed4cb0d741058fe blob - 523255765024b9f0f9ea234cd25ea610ab786149 blob + 6752c0627ef4e2d7deb01336f8d2d1ddb31bb379 --- cmd/Jira/create.go +++ cmd/Jira/create.go @@ -37,7 +37,7 @@ func (w *awin) put() error { if err != nil { return fmt.Errorf("read issue: %w", err) } - if _, err := f.Client.CreateIssue(*issue); err != nil { + if err := f.Client.CreateIssue(*issue); err != nil { return fmt.Errorf("create issue: %w", err) } } blob - 07014927557760f42e5abfb20972f21ee6f02c40 blob + cf941e1299c97b290b7e9fabfd6a0e8bf5c61678 --- jira/http.go +++ jira/http.go @@ -128,26 +128,22 @@ func (c *Client) Comment(ikey, id string) (*Comment, e return &com, err } -func (c *Client) CreateIssue(issue Issue) (*Issue, error) { +func (c *Client) CreateIssue(issue Issue) error { u := *c.APIRoot u.Path = path.Join(u.Path, "issue") resp, err := c.postJSON(u.String(), &issue) if err != nil { - return nil, fmt.Errorf("post json: %w", err) + return fmt.Errorf("post json: %w", err) } defer resp.Body.Close() if resp.StatusCode >= http.StatusBadRequest { var eresp errorResponse if err := json.NewDecoder(resp.Body).Decode(&eresp); err != nil { - return nil, fmt.Errorf("status %s: decode error response: %w", resp.Status, err) + return fmt.Errorf("status %s: decode error response: %w", resp.Status, err) } - return nil, eresp + return eresp } - var created Issue - if err := json.NewDecoder(resp.Body).Decode(&created); err != nil { - return nil, fmt.Errorf("decode created issue: %w", err) - } - return &created, nil + return nil } func (c *Client) PostComment(issueKey string, body io.Reader) error {