streaming

commit 4e0d54252adb799a9a5f9322295153558bfd3bf3
parent 63e18e7130b326684f3b78af8676cd9bd0a5f313
Author: Oliver Lowe <o@olowe.co>
Date:   Sun, 23 Jun 2024 19:35:10 +1000

rtp: always set packet header in session

By making the Session.Transmit a deliberately
high-level we don't need to complicate the implementation by checking
if stuff in the packet header is set or not. We'll need to document a
lower-level way to transmit packets without Session.

Diffstat:
M
rtp/session.go
 | 
10
+++-------

1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/rtp/session.go b/rtp/session.go
@@ -20,7 +20,6 @@ func Dial(network, addr string) (*Session, error) {
 // Session represents a RTP session... TODO(otl)
 // When a Session is established with Dial(), ...
 type Session struct {
-	Type PayloadType
 	// Clock is the rate of the... in hertz.
 	// If zero, automatic detection attempted...
 	Clock int
@@ -38,24 +37,21 @@ func (s *Session) init() {
 	s.timestamp = rand.Uint32()
 }
 
-// Transmit sends the encoded form of packet to the destination address in s.
-// The Session will manage
+// Transmit sends the packet to the destination address in s.
 func (s *Session) Transmit(packet *Packet) error {
 	if packet.Header.Version == 0 {
 		packet.Header.Version = VersionRFC3550
 	}
 
-	packet.Header.Sequence = s.sequence
 	s.sequence++
+	packet.Header.Sequence = s.sequence
 
 	ticks := ticksSince(s.previous, s.Clock)
 	packet.Header.Timestamp = s.timestamp + ticks
 	s.previous = time.Now()
 	s.timestamp += ticks
 
-	if packet.Header.SyncSource == 0 {
-		packet.Header.SyncSource = s.syncSource
-	}
+	packet.Header.SyncSource = s.syncSource
 
 	b, err := Marshal(packet)
 	if err != nil {