commit bc5be5eb901131c5b405a25e8eaba5f22637c691
parent b2a5207fc97673553514c6a413e7c6f516c5da00
Author: Oliver Lowe <o@olowe.co>
Date: Sat, 11 May 2024 19:35:47 +1000
internal/scte35: replace binary.PutUint* with AppendUint* where appropriate
Instead of allocating our own new buffer
Diffstat:
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/internal/scte35/splice_descriptor.go b/internal/scte35/splice_descriptor.go
@@ -35,9 +35,7 @@ func encodeSpliceDescriptor(sd SpliceDescriptor) []byte {
var buf []byte
buf = append(buf, byte(sd.Tag()))
buf = append(buf, byte(len(sd.Data())))
- ibuf := make([]byte, 4) // uint32 length
- binary.LittleEndian.PutUint32(ibuf, sd.ID())
- buf = append(buf, ibuf...)
+ buf = binary.LittleEndian.AppendUint32(buf, sd.ID())
return append(buf, sd.Data()...)
}
diff --git a/internal/scte35/splice_info.go b/internal/scte35/splice_info.go
@@ -116,14 +116,9 @@ func encodeSpliceInfo(sis *SpliceInfo) ([]byte, error) {
for _, desc := range sis.Descriptors {
buf1 = append(buf1, encodeSpliceDescriptor(desc)...)
}
- b := make([]byte, 2)
- binary.LittleEndian.PutUint16(b, uint16(len(buf1)))
- buf = append(buf, b...)
+ buf = binary.BigEndian.AppendUint16(buf, uint16(len(buf1)))
- b = make([]byte, 4)
- binary.LittleEndian.PutUint32(b, calculateCRC32(buf))
- buf = append(buf, b...)
- return buf, nil
+ return binary.BigEndian.AppendUint32(buf, calculateCRC32(buf)), nil
}
func packTier(tier uint16) [2]byte {