talons

commit 27534b6ba53ff71d4bb935490db9e6e64c7a820f
parent 4d6d31e8c5e6b16dabd253e3b70eaf1aa02a0313
Author: Colin Leroy <colin@colino.net>
Date:   Sun,  7 Jul 2019 18:44:54 +0200

Fix dereferencing of potentially NULL *error

Diffstat:
M
src/procmime.c
 | 
7
++-----

1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/procmime.c b/src/procmime.c
@@ -2789,16 +2789,13 @@ GdkPixbuf *procmime_get_part_as_pixbuf(MimeInfo *mimeinfo, GError **error)
 		*error = NULL;
 
 	stream = procmime_get_part_as_inputstream(mimeinfo);
-	if (stream == NULL) {
-		if (*error)
-			*error = g_error_new_literal(G_FILE_ERROR, -1, _("Could not decode part"));
+	if (stream == NULL)
 		return NULL;
-	}
 
 	pixbuf = gdk_pixbuf_new_from_stream(stream, NULL, error);
 	g_object_unref(stream);
 
-	if (*error != NULL)
+	if (error && *error != NULL)
 		return NULL;
 
 	return pixbuf;