talons

commit 444054e68dc8f3c273b18e5162348f7c96c21a3b
parent 701a0babe91bb8e11544113a3f3748782d589868
Author: Ricardo Mones <ricardo@mones.org>
Date:   Fri, 19 Feb 2016 19:23:00 +0100

Fix leak on error and error reporting

Diffstat:
M
src/plugins/pgpcore/pgp_utils.c
 | 
6
++++--

1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/plugins/pgpcore/pgp_utils.c b/src/plugins/pgpcore/pgp_utils.c
@@ -76,12 +76,14 @@ gchar *get_part_as_string(MimeInfo *mimeinfo)
 	else {
 		filename = procmime_get_tmp_file_name(mimeinfo);
 		if (procmime_get_part(filename, mimeinfo) < 0) {
-			printf("error dumping file\n");
+			g_warning("error dumping temporary file '%s'", filename);
+			g_free(filename);
 			return NULL;
 		}
 		fp = g_fopen(filename,"rb");
 		if (!fp) {
-			printf("error reading file\n");
+			g_warning("error opening temporary file '%s'", filename);
+			g_free(filename);
 			return NULL;
 		}
 		textdata = fp_read_noconv(fp);