talons

commit 589150b9d9ce105644592595ea44ea6d3014e121
parent 0f01f386bf387482746d87700a6bd2aef93ec0e3
Author: Ricardo Mones <ricardo@mones.org>
Date:   Wed, 19 Feb 2014 01:36:37 +0100

Remove some X-Face cruft and check after realloc

Diffstat:
M
src/headerview.c
 | 
15
---------------
M
src/plugins/pgpcore/sgpgme.c
 | 
4
++++
M
src/textview.c
 | 
4
----

3 files changed, 4 insertions(+), 19 deletions(-)
diff --git a/src/headerview.c b/src/headerview.c
@@ -47,10 +47,6 @@
 #include "addrindex.h"
 
 #if HAVE_LIBCOMPFACE
-#define XPM_XFACE_HEIGHT	(HEIGHT + 3)  /* 3 = 1 header + 2 colors */
-
-static gchar *xpm_xface[XPM_XFACE_HEIGHT];
-
 static gint headerview_show_xface	(HeaderView	*headerview,
 					 MsgInfo	*msginfo);
 #endif
@@ -193,17 +189,6 @@ void headerview_init(HeaderView *headerview)
 	headerview_set_font(headerview);
 	headerview_clear(headerview);
 	headerview_set_visibility(headerview, prefs_common.display_header_pane);
-
-#if HAVE_LIBCOMPFACE
-	{
-		gint i;
-
-		for (i = 0; i < XPM_XFACE_HEIGHT; i++) {
-			xpm_xface[i] = g_malloc(WIDTH + 1);
-			*xpm_xface[i] = '\0';
-		}
-	}
-#endif
 }
 
 void headerview_show(HeaderView *headerview, MsgInfo *msginfo)
diff --git a/src/plugins/pgpcore/sgpgme.c b/src/plugins/pgpcore/sgpgme.c
@@ -947,6 +947,10 @@ void *sgpgme_data_release_and_get_mem(gpgme_data_t data, size_t *len)
 	cm_gpgme_data_rewind(data);
 	while ((r = gpgme_data_read(data, buf, BUFSIZ)) > 0) {
 		result = realloc(result, r + w);
+		if (result == NULL) {
+			g_warning("can't allocate memory\n");
+			return NULL;
+		}
 		memcpy(result+w, buf, r);
 		w += r;
 	}
diff --git a/src/textview.c b/src/textview.c
@@ -41,10 +41,6 @@
 #  include <compface.h>
 #endif
 
-#if HAVE_LIBCOMPFACE
-#define XPM_XFACE_HEIGHT	(HEIGHT + 3)  /* 3 = 1 header + 2 colors */
-#endif
-
 #include "main.h"
 #include "summaryview.h"
 #include "procheader.h"