talons

commit 92074af6a19075e9865bfb573013b8ca48da73a2
parent c992286253f10e928362583d2fd2676e6c48f405
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Wed, 13 Mar 2019 20:54:20 +0100

Fix two small memory leaks in addressbook code

In each case, the GList structure itself was not
being freed.

Diffstat:
M
src/addrbook.c
 | 
5
++---
M
src/editgroup.c
 | 
3
+--

2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/addrbook.c b/src/addrbook.c
@@ -1606,7 +1606,7 @@ static void addrbook_build_avail_email_vis(gpointer key, gpointer value,
 /**
  * Return link list of available email items that have not already been linked
  * to groups. Note that the list contains references to items and should be
- * <code>g_free()</code> when done. Do <b>*NOT*</b> attempt to used the
+ * <code>g_list_free()</code> when done. Do <b>*NOT*</b> attempt to used the
  * <code>addrbook_free_xxx()<code> functions... this will destroy the
  * addressbook data!
  *
@@ -1672,8 +1672,7 @@ void addrbook_update_group_list(AddressBookFile *book, ItemGroup *group,
 	/* Remember old list */
 	oldData = group->listEMail;
 	group->listEMail = listEMail;
-	mgu_clear_list(oldData);
-	oldData = NULL;
+	g_list_free(oldData);
 }
 
 /**
diff --git a/src/editgroup.c b/src/editgroup.c
@@ -505,8 +505,7 @@ ItemGroup *addressbook_edit_group( AddressBookFile *abf, ItemFolder *parent, Ite
 
 	listEMail = addrbook_get_available_email_list( abf, group );
 	edit_group_load_clist( groupeditdlg.clist_avail, listEMail );
-	mgu_clear_list( listEMail );
-	listEMail = NULL;
+	g_list_free( listEMail );
 	gtk_cmclist_select_row( groupeditdlg.clist_group, 0, 0 );
 	gtk_cmclist_select_row( groupeditdlg.clist_avail, 0, 0 );