commit a471705042de8306ee3b8e12b1774747f4f9f1ac parent 65b78c0c8a3dbae0cbb315a3dc75f83c0e3f16fa Author: wwp <subscript@free.fr> Date: Wed, 6 Oct 2021 12:04:33 +0200 Fix CID 1491290: dereference before null check. Diffstat:
| M | src/addressbook.c | | | 10 | ++++++---- |
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/addressbook.c b/src/addressbook.c @@ -3636,10 +3636,12 @@ gchar *addressbook_set_col_name_guard(gchar *value) { gchar *ret = "<not set>"; gchar *tmp = g_strdup(value); - g_strstrip(tmp); - if (tmp !=NULL && *tmp != '\0') - ret = value; - g_free(tmp); + if (tmp) { + g_strstrip(tmp); + if (*tmp != '\0') + ret = value; + g_free(tmp); + } return ret; }