talons

commit c8cb6c4ce1f6b9ea2838c8288a3f32923d1d7f6e
parent 3c182109663906bb388798f0cc7587fdfdeb1d60
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Wed, 29 May 2019 19:10:28 +0200

Get rid of magic numbers in summary_msginfo_*_flags

Diffstat:
M
src/summaryview.c
 | 
19
++++++++++++-------

1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/summaryview.c b/src/summaryview.c
@@ -3599,9 +3599,14 @@ static void summary_display_msg(SummaryView *summaryview, GtkCMCTreeNode *row)
 }
 
 static gboolean defer_change(gpointer data);
+typedef enum {
+	FLAGS_UNSET,
+	FLAGS_SET,
+	FLAGS_CHANGE
+} ChangeType;
 typedef struct _ChangeData {
 	MsgInfo *info;
-	gint op; /* 0, 1, 2 for unset, set, change */
+	ChangeType op;
 	MsgPermFlags set_flags;
 	MsgTmpFlags  set_tmp_flags;
 	MsgPermFlags unset_flags;
@@ -3616,7 +3621,7 @@ static void summary_msginfo_unset_flags(MsgInfo *msginfo, MsgPermFlags flags, Ms
 	} else {
 		ChangeData *unset_data = g_new0(ChangeData, 1);
 		unset_data->info = msginfo;
-		unset_data->op = 0;
+		unset_data->op = FLAGS_UNSET;
 		unset_data->unset_flags = flags;
 		unset_data->unset_tmp_flags = tmp_flags;
 		debug_print("flags: deferring unset\n");
@@ -3632,7 +3637,7 @@ static void summary_msginfo_set_flags(MsgInfo *msginfo, MsgPermFlags flags, MsgT
 	} else {
 		ChangeData *set_data = g_new0(ChangeData, 1);
 		set_data->info = msginfo;
-		set_data->op = 1;
+		set_data->op = FLAGS_SET;
 		set_data->set_flags = flags;
 		set_data->set_tmp_flags = tmp_flags;
 		debug_print("flags: deferring set\n");
@@ -3651,7 +3656,7 @@ static void summary_msginfo_change_flags(MsgInfo *msginfo,
 	} else {
 		ChangeData *change_data = g_new0(ChangeData, 1);
 		change_data->info = msginfo;
-		change_data->op = 2;
+		change_data->op = FLAGS_CHANGE;
 		change_data->set_flags = add_flags;
 		change_data->set_tmp_flags = add_tmp_flags;
 		change_data->unset_flags = rem_flags;
@@ -3670,13 +3675,13 @@ gboolean defer_change(gpointer data)
 	} else {
 		debug_print("flags: finally doing it\n");
 		switch(chg->op) {
-		case 0:
+		case FLAGS_UNSET:
 			procmsg_msginfo_unset_flags(chg->info, chg->unset_flags, chg->unset_tmp_flags);
 			break;
-		case 1:
+		case FLAGS_SET:
 			procmsg_msginfo_set_flags(chg->info, chg->set_flags, chg->set_tmp_flags);
 			break;
-		case 2:
+		case FLAGS_CHANGE:
 			procmsg_msginfo_change_flags(chg->info, chg->set_flags, chg->set_tmp_flags,
 				chg->unset_flags, chg->unset_tmp_flags);
 			break;