talons

commit d44c5d96dc8415c5fa5888bf8490653b85aba1e8
parent 6e0856ba50f76742c443fe2e47d802261502306b
Author: Ricardo Mones <ricardo@mones.org>
Date:   Sat, 10 Feb 2024 20:00:52 +0100

Fix CIDs 1491064 and 1491074

Two instances of 'Use after free (USE_AFTER_FREE)'

Diffstat:
M
src/common/xml.c
 | 
2
+-
M
src/mimeview.c
 | 
2
+-

2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/xml.c b/src/common/xml.c
@@ -361,8 +361,8 @@ static void xml_pop_tag(XMLFile *file)
 
 	tag = (XMLTag *)file->tag_stack->data;
 
-	xml_free_tag(tag);
 	file->tag_stack = g_list_remove(file->tag_stack, tag);
+	xml_free_tag(tag);
 	file->level--;
 }
 
diff --git a/src/mimeview.c b/src/mimeview.c
@@ -597,8 +597,8 @@ void mimeview_destroy(MimeView *mimeview)
 	mimeview_free_mimeinfo(mimeview);
 	gtk_tree_path_free(mimeview->opened);
 	g_free(mimeview->file);
-	g_free(mimeview);
 	mimeviews = g_slist_remove(mimeviews, mimeview);
+	g_free(mimeview);
 }
 
 MimeInfo *mimeview_get_selected_part(MimeView *mimeview)